2022-12-12 19:29:09 +08:00
|
|
|
From: Yousong Zhou <yszhou4tech@gmail.com>
|
|
|
|
Subject: [PATCH] ath79: add nvmem cell mac-address-ascii support
|
|
|
|
|
|
|
|
This is needed for devices with mac address stored in ascii format, e.g.
|
|
|
|
HiWiFi HC6361 to be ported in the following patch.
|
|
|
|
|
|
|
|
Submitted-by: Yousong Zhou <yszhou4tech@gmail.com>
|
|
|
|
---
|
|
|
|
net/ethernet/eth.c | 83 ++++++++++++------
|
|
|
|
1 files changed, 72 insertions(+), 11 deletions(-)
|
|
|
|
|
|
|
|
--- a/net/ethernet/eth.c
|
|
|
|
+++ b/net/ethernet/eth.c
|
2024-05-18 15:50:13 +08:00
|
|
|
@@ -505,6 +505,63 @@ int eth_platform_get_mac_address(struct
|
2022-12-12 19:29:09 +08:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(eth_platform_get_mac_address);
|
|
|
|
|
|
|
|
+static void *nvmem_cell_get_mac_address(struct nvmem_cell *cell)
|
|
|
|
+{
|
|
|
|
+ size_t len;
|
|
|
|
+ void *mac;
|
|
|
|
+
|
|
|
|
+ mac = nvmem_cell_read(cell, &len);
|
|
|
|
+ if (IS_ERR(mac))
|
2022-12-13 00:15:28 +01:00
|
|
|
+ return mac;
|
2022-12-12 19:29:09 +08:00
|
|
|
+ if (len != ETH_ALEN) {
|
|
|
|
+ kfree(mac);
|
|
|
|
+ return ERR_PTR(-EINVAL);
|
|
|
|
+ }
|
|
|
|
+ return mac;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static void *nvmem_cell_get_mac_address_ascii(struct nvmem_cell *cell)
|
|
|
|
+{
|
|
|
|
+ size_t len;
|
|
|
|
+ int ret;
|
|
|
|
+ void *mac_ascii;
|
|
|
|
+ u8 *mac;
|
|
|
|
+
|
|
|
|
+ mac_ascii = nvmem_cell_read(cell, &len);
|
|
|
|
+ if (IS_ERR(mac_ascii))
|
2022-12-13 00:15:28 +01:00
|
|
|
+ return mac_ascii;
|
2022-12-12 19:29:09 +08:00
|
|
|
+ if (len != ETH_ALEN*2+5) {
|
|
|
|
+ kfree(mac_ascii);
|
|
|
|
+ return ERR_PTR(-EINVAL);
|
|
|
|
+ }
|
|
|
|
+ mac = kmalloc(ETH_ALEN, GFP_KERNEL);
|
|
|
|
+ if (!mac) {
|
|
|
|
+ kfree(mac_ascii);
|
|
|
|
+ return ERR_PTR(-ENOMEM);
|
|
|
|
+ }
|
|
|
|
+ ret = sscanf(mac_ascii, "%2hhx:%2hhx:%2hhx:%2hhx:%2hhx:%2hhx",
|
|
|
|
+ &mac[0], &mac[1], &mac[2],
|
|
|
|
+ &mac[3], &mac[4], &mac[5]);
|
|
|
|
+ kfree(mac_ascii);
|
|
|
|
+ if (ret == ETH_ALEN)
|
|
|
|
+ return mac;
|
|
|
|
+ kfree(mac);
|
|
|
|
+ return ERR_PTR(-EINVAL);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static struct nvmem_cell_mac_address_property {
|
|
|
|
+ char *name;
|
|
|
|
+ void *(*read)(struct nvmem_cell *);
|
|
|
|
+} nvmem_cell_mac_address_properties[] = {
|
|
|
|
+ {
|
|
|
|
+ .name = "mac-address",
|
|
|
|
+ .read = nvmem_cell_get_mac_address,
|
|
|
|
+ }, {
|
|
|
|
+ .name = "mac-address-ascii",
|
|
|
|
+ .read = nvmem_cell_get_mac_address_ascii,
|
|
|
|
+ },
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
/**
|
|
|
|
* platform_get_ethdev_address - Set netdev's MAC address from a given device
|
|
|
|
* @dev: Pointer to the device
|
2024-05-18 15:50:13 +08:00
|
|
|
@@ -538,19 +595,23 @@ int nvmem_get_mac_address(struct device
|
2022-12-12 19:29:09 +08:00
|
|
|
{
|
|
|
|
struct nvmem_cell *cell;
|
|
|
|
const void *mac;
|
|
|
|
- size_t len;
|
kernel: bump 5.15 to 5.15.86 (#10708)
* kernel: bump 5.15 to 5.15.86
Removed upstreamed:
pending-5.15/101-Use-stddefs.h-instead-of-compiler.h.patch[1]
ipq60xx/patches-5.15/0171-arm64-dts-qcom-ipq6018-cp01-c1-use-BLSPI1-pins.patch
ipq806x/patches-5.15/122-01-clk-qcom-clk-krait-fix-wrong-div2-functions.patch[2]
ipq60xx/patches-5.15/0139-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
ipq60xx/patches-5.15/0005-v5.16-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
ipq807x/patches-5.15/0004-v5.16-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
bcm27xx/patches-5.15/950-0198-drm-fourcc-Add-packed-10bit-YUV-4-2-0-format.patch[3]
Manually rebased:
ramips/patches-5.15/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch[4]
Added patch/backported:
ramips/patches-5.15/107-PCI-mt7621-Add-sentinel-to-quirks-table.patch[5]
All other patches automatically rebased.
1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.86&id=c160505c9b574b346031fdf2c649d19e7939ca11
2. Cannot find in the stable tree but it is here: https://github.com/torvalds/linux/commit/a051e10bfc6906d29dae7a31f0773f2702edfe1b
3. https://github.com/gregkh/linux/commit/ec1727f89ecd6f2252c0c75e200058819f7ce47a
4. Quilt gave this output when I applied the patch to rebase it:
% quilt push -f
Applying patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch
patching file arch/mips/ralink/Kconfig
patching file drivers/pci/controller/Kconfig
patching file drivers/pci/controller/Makefile
patching file drivers/staging/Kconfig
patching file drivers/staging/Makefile
patching file drivers/staging/mt7621-pci/Kconfig
patching file drivers/staging/mt7621-pci/Makefile
patching file drivers/staging/mt7621-pci/TODO
patching file drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt
patching file drivers/staging/mt7621-pci/pci-mt7621.c
Hunk #1 FAILED at 1.
Not deleting file drivers/staging/mt7621-pci/pci-mt7621.c as content differs from patch
1 out of 1 hunk FAILED -- saving rejects to file drivers/staging/mt7621-pci/pci-mt7621.c.rej
patching file drivers/pci/controller/pcie-mt7621.c
Applied patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch (forced; needs refresh)
Upon inspecting drivers/staging/mt7621-pci/pci-mt7621.c.rej, it seems that
the original patch wants to delete drivers/staging/mt7621-pci/pci-mt7621.c
but upstream's version was not an exact match. I opted to delete that file
and need some feedback. Was that the correct course of action?
5. Suggestion by hauke: https://github.com/torvalds/linux/commit/19098934f910b4d47cb30251dd39ffa57bef9523
"This patch is in upstream kernel, but it was backported to the old
staging driver in kernel 5.15."
Build system: x86_64
Build-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod
Signed-off-by: John Audia <therealgraysky@proton.me>
Signed-off-by: Linhui Liu <liulinhui36@gmail.com>
* oxnas: sata_oxnas: use ata_link_err
Kernel 5.15.86 has backported ("ata: libata: move ata_{port,link,dev}_dbg
to standard pr_XXX() macros") and this is now causing compilation errors
for oxnas SATA driver due to usage of ata_link_printk().
Upstream has migrated to using the appropriate
ata_link_{err, warn, notice, info} calls a while ago so its not affected.
Lets do the same for oxnas SATA driver and use ata_link_err() instead of
ata_link_printk().
Signed-off-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: John Audia <therealgraysky@proton.me>
Signed-off-by: Linhui Liu <liulinhui36@gmail.com>
Signed-off-by: Robert Marko <robimarko@gmail.com>
Co-authored-by: John Audia <therealgraysky@proton.me>
Co-authored-by: Robert Marko <robimarko@gmail.com>
2023-01-02 14:11:40 +08:00
|
|
|
-
|
2022-12-12 19:29:09 +08:00
|
|
|
- cell = nvmem_cell_get(dev, "mac-address");
|
|
|
|
- if (IS_ERR(cell))
|
|
|
|
- return PTR_ERR(cell);
|
|
|
|
-
|
|
|
|
- mac = nvmem_cell_read(cell, &len);
|
|
|
|
- nvmem_cell_put(cell);
|
kernel: bump 5.15 to 5.15.86 (#10708)
* kernel: bump 5.15 to 5.15.86
Removed upstreamed:
pending-5.15/101-Use-stddefs.h-instead-of-compiler.h.patch[1]
ipq60xx/patches-5.15/0171-arm64-dts-qcom-ipq6018-cp01-c1-use-BLSPI1-pins.patch
ipq806x/patches-5.15/122-01-clk-qcom-clk-krait-fix-wrong-div2-functions.patch[2]
ipq60xx/patches-5.15/0139-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
ipq60xx/patches-5.15/0005-v5.16-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
ipq807x/patches-5.15/0004-v5.16-arm64-dts-qcom-Correct-QMP-PHY-child-node-name.patch
bcm27xx/patches-5.15/950-0198-drm-fourcc-Add-packed-10bit-YUV-4-2-0-format.patch[3]
Manually rebased:
ramips/patches-5.15/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch[4]
Added patch/backported:
ramips/patches-5.15/107-PCI-mt7621-Add-sentinel-to-quirks-table.patch[5]
All other patches automatically rebased.
1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.86&id=c160505c9b574b346031fdf2c649d19e7939ca11
2. Cannot find in the stable tree but it is here: https://github.com/torvalds/linux/commit/a051e10bfc6906d29dae7a31f0773f2702edfe1b
3. https://github.com/gregkh/linux/commit/ec1727f89ecd6f2252c0c75e200058819f7ce47a
4. Quilt gave this output when I applied the patch to rebase it:
% quilt push -f
Applying patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch
patching file arch/mips/ralink/Kconfig
patching file drivers/pci/controller/Kconfig
patching file drivers/pci/controller/Makefile
patching file drivers/staging/Kconfig
patching file drivers/staging/Makefile
patching file drivers/staging/mt7621-pci/Kconfig
patching file drivers/staging/mt7621-pci/Makefile
patching file drivers/staging/mt7621-pci/TODO
patching file drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt
patching file drivers/staging/mt7621-pci/pci-mt7621.c
Hunk #1 FAILED at 1.
Not deleting file drivers/staging/mt7621-pci/pci-mt7621.c as content differs from patch
1 out of 1 hunk FAILED -- saving rejects to file drivers/staging/mt7621-pci/pci-mt7621.c.rej
patching file drivers/pci/controller/pcie-mt7621.c
Applied patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch (forced; needs refresh)
Upon inspecting drivers/staging/mt7621-pci/pci-mt7621.c.rej, it seems that
the original patch wants to delete drivers/staging/mt7621-pci/pci-mt7621.c
but upstream's version was not an exact match. I opted to delete that file
and need some feedback. Was that the correct course of action?
5. Suggestion by hauke: https://github.com/torvalds/linux/commit/19098934f910b4d47cb30251dd39ffa57bef9523
"This patch is in upstream kernel, but it was backported to the old
staging driver in kernel 5.15."
Build system: x86_64
Build-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod
Signed-off-by: John Audia <therealgraysky@proton.me>
Signed-off-by: Linhui Liu <liulinhui36@gmail.com>
* oxnas: sata_oxnas: use ata_link_err
Kernel 5.15.86 has backported ("ata: libata: move ata_{port,link,dev}_dbg
to standard pr_XXX() macros") and this is now causing compilation errors
for oxnas SATA driver due to usage of ata_link_printk().
Upstream has migrated to using the appropriate
ata_link_{err, warn, notice, info} calls a while ago so its not affected.
Lets do the same for oxnas SATA driver and use ata_link_err() instead of
ata_link_printk().
Signed-off-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: John Audia <therealgraysky@proton.me>
Signed-off-by: Linhui Liu <liulinhui36@gmail.com>
Signed-off-by: Robert Marko <robimarko@gmail.com>
Co-authored-by: John Audia <therealgraysky@proton.me>
Co-authored-by: Robert Marko <robimarko@gmail.com>
2023-01-02 14:11:40 +08:00
|
|
|
+ struct nvmem_cell_mac_address_property *property;
|
|
|
|
+ int i;
|
|
|
|
|
2022-12-12 19:29:09 +08:00
|
|
|
- if (IS_ERR(mac))
|
|
|
|
- return PTR_ERR(mac);
|
|
|
|
+ for (i = 0; i < ARRAY_SIZE(nvmem_cell_mac_address_properties); i++) {
|
|
|
|
+ property = &nvmem_cell_mac_address_properties[i];
|
|
|
|
+ cell = nvmem_cell_get(dev, property->name);
|
|
|
|
+ if (IS_ERR(cell)) {
|
|
|
|
+ if (i == ARRAY_SIZE(nvmem_cell_mac_address_properties) - 1)
|
|
|
|
+ return PTR_ERR(cell);
|
|
|
|
+ continue;
|
|
|
|
+ }
|
|
|
|
+ mac = property->read(cell);
|
|
|
|
+ nvmem_cell_put(cell);
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
|
|
|
|
|
|
- if (len != ETH_ALEN || !is_valid_ether_addr(mac)) {
|
|
|
|
+ if (!is_valid_ether_addr(mac)) {
|
|
|
|
kfree(mac);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|