mirror of
https://github.com/coolsnowwolf/lede.git
synced 2025-06-08 21:42:04 +08:00
41 lines
1.3 KiB
Diff
41 lines
1.3 KiB
Diff
|
From 34501d047ac0a6cbb13285ba9d15f75c1deb7da7 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Christian Marangi <ansuelsmth@gmail.com>
|
||
|
|
Date: Tue, 15 Apr 2025 12:53:05 +0200
|
||
|
|
Subject: [PATCH 18/20] net: phy: mediatek: init val in .phy_led_polarity_set
|
||
|
|
for AN7581
|
||
|
|
|
||
|
|
Fix smatch warning for uninitialised val in .phy_led_polarity_set for
|
||
|
|
AN7581 driver.
|
||
|
|
|
||
|
|
Correctly init to 0 to set polarity high by default.
|
||
|
|
|
||
|
|
Reported-by: Simon Horman <horms@kernel.org>
|
||
|
|
Fixes: 6a325aed130b ("net: phy: mediatek: add Airoha PHY ID to SoC driver")
|
||
|
|
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
|
||
|
|
Link: https://patch.msgid.link/20250415105313.3409-1-ansuelsmth@gmail.com
|
||
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
||
|
|
---
|
||
|
|
drivers/net/phy/mediatek/mtk-ge-soc.c | 3 +--
|
||
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/phy/mediatek/mtk-ge-soc.c
|
||
|
|
+++ b/drivers/net/phy/mediatek/mtk-ge-soc.c
|
||
|
|
@@ -1431,8 +1431,8 @@ static int an7581_phy_probe(struct phy_d
|
||
|
|
static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index,
|
||
|
|
unsigned long modes)
|
||
|
|
{
|
||
|
|
+ u16 val = 0;
|
||
|
|
u32 mode;
|
||
|
|
- u16 val;
|
||
|
|
|
||
|
|
if (index >= MTK_PHY_MAX_LEDS)
|
||
|
|
return -EINVAL;
|
||
|
|
@@ -1443,7 +1443,6 @@ static int an7581_phy_led_polarity_set(s
|
||
|
|
val = MTK_PHY_LED_ON_POLARITY;
|
||
|
|
break;
|
||
|
|
case PHY_LED_ACTIVE_HIGH:
|
||
|
|
- val = 0;
|
||
|
|
break;
|
||
|
|
default:
|
||
|
|
return -EINVAL;
|