298977887/setup-python
1
0
Fork 0
mirror of https://github.com/actions/setup-python.git synced 2025-04-20 03:53:30 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Trim trailing space from discovered Python versions.

Browse Source 
The setup-python action failed because my .python-version (generated from a recent pyenv) had a trailing newline (not sure if this is a bug in pyenv, but I'll look there next). 

```
Installed versions
  Version 3.11.3
   was not found in the local cache
  Error: The version '3.11.3
  ' with architecture 'x64' was not found for Ubuntu 18.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
```

As you can see, the version was not discovered because the newline didn't match exactly. The way I figure, even if this is user error, stripping trailing space is super easy, and will probably prevent some problems.
This commit is contained in:
Andrew Gwozdziewycz 2023-05-09 16:45:46 +00:00 committed by GitHub
parent db9987b4c1
commit d14c82c718
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/setup-python.ts
View File

@ -42,7 +42,7 @@ function resolveVersionInput() {
`The specified python version file at: ${versionFile} doesn't exist.` `The specified python version file at: ${versionFile} doesn't exist.`
); );
} }
const version = fs.readFileSync(versionFile, 'utf8'); const version = fs.readFileSync(versionFile, 'utf8').trimEnd();
core.info(`Resolved ${versionFile} as ${version}`); core.info(`Resolved ${versionFile} as ${version}`);
return [version]; return [version];
} }
@ -52,7 +52,7 @@ function resolveVersionInput() {
); );
versionFile = '.python-version'; versionFile = '.python-version';
if (fs.existsSync(versionFile)) { if (fs.existsSync(versionFile)) {
const version = fs.readFileSync(versionFile, 'utf8'); const version = fs.readFileSync(versionFile, 'utf8').trimEnd();
core.info(`Resolved ${versionFile} as ${version}`); core.info(`Resolved ${versionFile} as ${version}`);
return [version]; return [version];
} }